kube-runtime: fix exponential backoff max times #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1713 +/- ##
=======================================
+ Coverage 75.8% 75.8% +0.1%
=======================================
Files 84 84
Lines 7746 7743 -3
=======================================
Hits 5866 5866
+ Misses 1880 1877 -3
🚀 New features to boost your workflow:
|
ExponentialBuilder::default() uses max_times=Some(3), which means it will give up after 3 times. call without_max_times() in order to avoid it. this matches the previous backoff-based implementation that called .with_max_elapsed_time(None) additionally, save the actual builder which contains all the relevant params, so we could reset it easily (the current implementation didn't use the same params in new() and reset()). Signed-off-by: Eliad Peller <eliad.peller@wiz.io>
eliad-wiz
force-pushed
the
fix-exponential-backoff
branch
from
cd992ca to
ac786b3
Compare
clux
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backon's
ExponentialBuilder::default()usesmax_times=Some(3), which means it will give up after 3 times.call
without_max_times()in order to avoid it.this matches the previous backoff-based implementation that called
.with_max_elapsed_time(None)additionally, save the actual builder which contains all the relevant params, so we could reset it easily (the current implementation has another bug where it doesn't use the same params in
new()andreset()).